Re: [patch] exporting indexes (v2)

Hi Nirgal,

All patches applied to master.  Am I correct in surmising that the
git.diff patch brings the code from 0.6pre1 to the current (prior to
the other patches) git repository level?

I have noticed a couple of problems after applying the patches.

First, the 'ole' patch changes mdb-export.c/print_col()

-        if (strlen(quote_char)==1 && c==quote_char[0]) {
+        if (strlen(quote_char)==1 && c==quote_char[0] || c==escape_char[0]) {

But if -X is not passed to mdb-export, then escape_char is NULL and we
segfault on the above code.  Possibly a misapplied patch, but can you
check it on your local copy?

Secondly, I am getting a message of 'Warning: incorrect memo length'
on a database that previously did not emit that error.  I need to
check into this one a bit more.

Brian

2011/2/10 Nirgal Vourgère <[email protected]>:
> I can see the patch about exporting indexes is not in the repository yet.
> It's good, so I had time to refine it a bit, renaming the function to match other ones, and changing the boolean parameters into a bits field (many more options coming soon).
>
> Here's a summary:
> * I was fed up with adding code both in util/mdb-schema.c and gmdb2/schema.c. These were mostly duplicated code.
> So I moved the common parts in libmdb/backend.c, that means a new function called "mdb_print_schema" that will call the relevant code.
>
> * Indexed now are generated for postgres backend: normal ones, unique ones, and primary keys.
>
> * Fixed a bug in where all the foreign keys were generated when you export only one table (added a parameter to mdb_get_relationships).
>
> * Now using PATH_MAX and MDB_MAX_OBJ_NAME macro for sizes of constants in gmdb2/schema.c, rather than hardcoded values 256/100.
>
> * The recent mdb_get_sequences was made static. It might change in the future (export autonum directly for some backend).
>
>
> I updated the other patches I'm working on in http://www.nirgal.com/mdbtools/debian.squeeze/debian/patches/
>
> ------------------------------------------------------------------------------
> The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
> Pinpoint memory and threading errors before they happen.
> Find and fix more than 250 security defects in the development cycle.
> Locate bottlenecks in serial and parallel code that limit performance.
> http://p.sf.net/sfu/intel-dev2devfeb
> _______________________________________________
> mdbtools-dev mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mdbtools-dev
>
>

------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb