inconsistency in source-code/comments in mf_keycache
Kuts Alexey <[email protected]> Tue, 05 Mar 2013 01:59:41 +0400
| Newsgroups | gmane.comp.db.mysql.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi,
I am just learning the inner working of myisam key cache
and found some inconsistency in mf_keycache.c
here is this place and my suggested patch:
--- mysys/mf_keycache.c 2011-09-07 10:08:09 +0000
+++ mysys/mf_keycache.c 2013-03-06 07:53:02 +0000
@@ -3404,7 +3404,7 @@
return;
/* Error blocks are not put into the LRU ring. */
- if (!(block->status & BLOCK_ERROR))
+ if (block->status & BLOCK_ERROR)
{
/* Here the block must be in the LRU ring. Unlink it again. */
DBUG_ASSERT(block->next_used && block->prev_used &&
I don't know, is there really a bug, that erroneous blocks are remained in LRU-ring.
Regards,
Alexey
--
MySQL Internals Mailing List
For list archives: http://lists.mysql.com/internals
To unsubscribe: http://lists.mysql.com/internals