Re: BUG #16190: The usage of NULL pointer in refint.c
Andres Freund <[email protected]> Mon, 06 Jan 2020 22:45:08 -0800
| Newsgroups | gmane.comp.db.postgresql.bugs |
|---|---|
| Message-ID | <[email protected]> |
On January 6, 2020 10:44:12 PM PST, Michael Paquier <michael@paquier=2Exyz= > wrote: >On Mon, Jan 06, 2020 at 06:26:54PM -0800, Andres Freund wrote: >> On 2020-01-06 21:12:05 -0500, Tom Lane wrote: >>> WFM=2E There are probably more elegant ways to do it than to drop >this >>> stuff into TopMemoryContext, but this is surely better than >unchecked >>> malloc calls=2E >>=20 >> Yea, it's certainly better than the current situation=2E An incremental >> improvement would be to do the allocations in a separate contect, for >easier >> debugging should there ever be a leak=2E=2E=2E > >Sure=2E I am not sure if that's worth the extra work though, so I would >just be tempted to commit the patch that moves the allocation to >TopMemoryContext and call it a day=2E Any objections to that? Not from here --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E