Re: libpq parameter parsing problem

--2NLGdgz3UMHa/lqP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jan 13, 2020 at 08:07:06PM +0530, Jobin Augustine wrote:
> Sorry for the late reply. Attaching a patch.

>     <para>
> -    Percent-encoding may be used to include symbols with special meaning=
 in any
> -    of the <acronym>URI</acronym> parts, e.g. replace <literal>=3D</lite=
ral> with
> -    <literal>%3D</literal>.
> -
> +    Connection <acronym>URI</acronym> need to be encoded with=20
> +    <ulink url=3D"https://en.wikipedia.org/wiki/Percent-encoding">Percen=
t-encoding</ulink>=20
> +    if it includes symbols with special meaning in any of its parts.=20
> +    For example:
> +<programlisting>
> +postgresql://postgres@localhost:5432/postgres?options=3D-c%20synchronous=
_commit%3Doff%20-c%20geqo%3Doff
> +</programlisting>
> +    where all <literal>=3D</literal> are replaced with <literal>%3D</lit=
eral> and=20
> +    space character with <literal>%20</literal>
>     </para>

The reference to wikipedia is nice to have.  A small nit from me is
that I would group the last sentence with the "For example", to give:
"Here is an example where all =3D are replaced.."

The first sentence sounds good to me.
--
Michael

--2NLGdgz3UMHa/lqP
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl4dWaQACgkQnvQgOdby
QH0EqQ//cF3A99ZGSVd+y7cL2rp2TeXDL3ydgRnAr0s7brikJAje07/QMwugevGQ
Z7hHV0yzwdC7vQwq1bHZ1kNPWKgUfoI9kjwZ3O0gWRZLyG1QFKZBDhFuMFxHIl4Z
dg87JJC9xS7jHB4kFCb/uUboC/ylWho7Tl1MCeNQ9bXwnfx6GhNbzHuqjA75sWsj
TWv6cMCSh/ao7VDwrx4ValAD6Cox33Ftrk7s7ItiJDpYWcaVLX8XOdo31ME1p+8F
uel+QQ942UbwvG/GIyn5uWTKCvxlAQoClAPUEUChmyUfYgd4n3UburtB/aowOIQo
YKWZJji3PhVoDlJUbyxzXBR2Jyo+B7B0mA3At+of7IGJYJp3AUxdzj49MLmYyd1v
GQYq2+yvYReNmuaJ7AL27jY1h1ZKLVjMe/GAM1tg0dRh3V8WE/WjeqlRkPINLvHb
o7wmMxvjxXFHKJerdDxHyLtE14aA3+gKnbDplDYm8xyFgYBj1a8he7cV0kVpAitd
nQbFsnHy9dyE7SaBhuqfW+Soo366TXkmPwoRJNlC+MApHSzi/Dam5Qvotvg3boKE
RoOpyCeOh/H2DeMCHjIFOjsPZ0Z84+10VkerjloGSd3mkBtX7OOuTFg0FnMl2xso
DR0stJKXeidVNMKbfTUgICuN/T50Izr0MBniE0/ERTagoHYgD9M=
=PAJL
-----END PGP SIGNATURE-----

--2NLGdgz3UMHa/lqP--