Re: libpq parameter parsing problem

--DWg365Y4B18r8evw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jan 14, 2020 at 06:52:07PM -0700, David G. Johnston wrote:
> I would probably choose to move the example for the options parameters to
> the "Parameter Key Words" options section:

I think that this would be inconsistent with the rest, as that's a URI
and all the other examples are there.  I agree with the feeling of
Alvaro upthread that we could do a better effort with the handling of
the examples in this section, but it is quite unclear to me if that
would actually bring more clarity to the whole, and that's not really
the job of this patch.

> Also, regardless of where it is placed having both the username and
> database both be named "postgres" in an example just adds unnecessary
> mental effort to understanding the example.  One that none of the existing
> examples do.  Name your user "user" and database "mydb" unless, as with the
> desire to include a space, there is a meaningful reason not to.

Good point.  Using "mydb" or "user" instead of "postgres" in the new
example would be less confusing.  Another question, would be it better
to use "5433" instead of "5432" for the port number.  That's a nit,
but as we are on that stuff let's be right..
--
Michael

--DWg365Y4B18r8evw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl4ee54ACgkQnvQgOdby
QH23Jg//bZAGBsI8mbTy6Do9F14aCiXcUyjHK+5JS+anuLYgl1UaMEMt1/m6Zkry
MSN8XqYXR9SeU7SKqUNfFQgUFhfBlpiaUlVbVtlBy/Sh02b8IYtUU5WYGJ+vtUku
lFXNQPRiyLdWT6DbPEv3r6T0YDtdfF6Zd7Yyz91rh5zYiRsX4ZuclrH7zg6JApqB
tUoiOvYRNugLSY6q0I3TRPu+Z/K+rcEQuMwu1Ia+MYucLkzSjPK8WjwDcfvsK91T
Lobli8u7rxQrzFarHo9+dk8v++jOcwl/QSKc4W4CBnhgQbybHQNhT4lMLpKvAKHr
V/GuO69fk27wxeL/ZXJt/iehhNJgt0nDfGAF7UQyF0+1mQRz7THqVcjEXNZ/UPJz
TRwVcrNQqJdQS2jbmNd4dgwzQYBQH2CmRk/NDTp33dXnp6C8I2NgFRXd7RN85B6Z
/O1a+dnasAC5Bf/zyVU2QIkHRVF6APTsuixIczL/BpektORL3Kz4gYP0PzAUjDH1
RjJ6o8wk4oSKC2oEzv2vJPttRgLYdOTorv12xvTmB83sAK4e5weqnGPq+XHZvqHX
F8+dyr7gVzfygNpk+QvFsTP2iiwRoewaKgEzQMqes+N3R5IapHIXZdTrmDnmEGs+
HYWm8WZRXdcZtmjZS1v2X2ZDey80Yrp5NnYrL7cFzsnQj/KVcio=
=pPmF
-----END PGP SIGNATURE-----

--DWg365Y4B18r8evw--