Re: postgresql-7.4.5-1 ready for review

Reini,

On Wed, Aug 25, 2004 at 08:09:26PM +0200, Reini Urban wrote:
> ok, postgresql-7.4.5-1 is ready.

Thanks, but I'm going to upload a postgresql-7.4.5-1 shortly.  Let's
transition maintainership in the 8.0 time frame.

> The problems were cygipc related (of course), which I patched away in
> configure.

AFAICT, there should not be any cygipc problems as long as it is not
installed on the build system.

> All tests passed ok (besides one minor cr/lf issue. see attached)

horology fails for me too, but the failure is due to daylight saving
issues (i.e., PDT vs. PST) not a textmode issue.

> just the setup.hint is missing. This is your (Jason) job :)

The setup.hint already on sources does not require any updating.

> The src package is similar to your old setup,
>   (orisrc/ plus orisrc/CYGWIN-PATCHES/)
> but it really should be changed to
> <orisrc>.tar.bz2 and the build and patch file.
> 
> I'll to change that with the 8.0.0beta1 package.

The above is fine -- just call me old fashioned... :,)

> Jason Tishler schrieb:
> >Hmm...  What does cygcheck indicate?
> 
> The problem was this autoconf line (configure.in):
> AC_CHECK_LIB(cygipc, shmget)
> 
> we have now "native" cygwin shmget support. so this check is bogus.
> we really should add a check if shmget is in sys/shm.h
> something like
> AC_CHECK_LIB(, shmget)

AFAICT, the above change is not necessary:

    checking for shmget in -lcygipc... no
    ...
    checking sys/ipc.h usability... yes
    checking sys/ipc.h presence... yes
    checking for sys/ipc.h... yes

Jason

-- 
PGP/GPG Key: http://www.tishler.net/jason/pubkey.asc or key servers
Fingerprint: 7A73 1405 7F2B E669 C19D  8784 1AFD E4CC ECF4 8EF6