[svn:DBD-Pg] r12858 - in DBD-Pg/trunk: . t

Author: turnstep
Date: Wed Jun 17 10:23:08 2009
New Revision: 12858

Modified:
   DBD-Pg/trunk/Makefile.PL
   DBD-Pg/trunk/t/02attribs.t
   DBD-Pg/trunk/t/12placeholders.t
   DBD-Pg/trunk/t/99_spellcheck.t

Log:
Minor Perl::Critic changes.


Modified: DBD-Pg/trunk/Makefile.PL
==============================================================================
--- DBD-Pg/trunk/Makefile.PL	(original)
+++ DBD-Pg/trunk/Makefile.PL	Wed Jun 17 10:23:08 2009
@@ -118,6 +118,7 @@
 	printf "The value of %s points to a non-existent directory: %s\n",
 		$path_name, $path;
 	$baddir++;
+	return;
 }
 
 does_path_exist('POSTGRES_HOME', $ENV{POSTGRES_HOME});

Modified: DBD-Pg/trunk/t/02attribs.t
==============================================================================
--- DBD-Pg/trunk/t/02attribs.t	(original)
+++ DBD-Pg/trunk/t/02attribs.t	Wed Jun 17 10:23:08 2009
@@ -1471,10 +1471,10 @@
 	$dbh->commit();
 
 	## This fails on some boxes, so we pull back all information to display why
-	my ($helpconnect, $connerror);
-	($helpconnect, $connerror, $dbh4) = connect_database();
+	my ($helpconnect2, $connerror2);
+	($helpconnect2, $connerror2, $dbh4) = connect_database();
 	if (! defined $dbh4) {
-		die "Database connection failed: helpconnect is $helpconnect, error is $connerror\n";
+		die "Database connection failed: helpconnect is $helpconnect2, error is $connerror2\n";
 	}
 	$dbh4->trace(0);
 	is ($dbh4->{ReadOnly}, undef, $t);

Modified: DBD-Pg/trunk/t/12placeholders.t
==============================================================================
--- DBD-Pg/trunk/t/12placeholders.t	(original)
+++ DBD-Pg/trunk/t/12placeholders.t	Wed Jun 17 10:23:08 2009
@@ -364,7 +364,7 @@
 $t='Bound placeholders enforce data types when not using server side prepares';
 $dbh->trace(0);
 $dbh->{pg_server_prepare} = 0;
-$sth = $dbh->prepare("SELECT (1+?+?)::integer");
+$sth = $dbh->prepare('SELECT (1+?+?)::integer');
 $sth->bind_param(1, 1, SQL_INTEGER);
 eval {
 	$sth->execute('10foo',20);

Modified: DBD-Pg/trunk/t/99_spellcheck.t
==============================================================================
--- DBD-Pg/trunk/t/99_spellcheck.t	(original)
+++ DBD-Pg/trunk/t/99_spellcheck.t	Wed Jun 17 10:23:08 2009
@@ -581,6 +581,9 @@
 conf
 danla
 david
+dll
+dllname
+dlltool
 dmake
 drnoble
 DynaLoader
@@ -600,6 +603,7 @@
 LDLOADLIBS
 MAKEFILE
 pc
+pexports
 PROGRA
 sandia
 sco
@@ -619,6 +623,7 @@
 Pg's
 qw
 Szilakszi
+uc
 
 ## Pg.pm:
 lseg