Re: [svn:DBD-Pg] r10637 - DBD-Pg/trunk

-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160


> What will you do if someone compiles a server with a larger
> NAMEDATALEN believeing, correctly, that the client won't know and
> shouldn't care?

They'll be sorry once they connect to another database... :)

> Wouldn't it be better to move the strlen() calls out of line and then
> reuse the result instead of a possibly bogus NAMEDATALEN?

Yes, you are right, this was a silly overreaction to splint's whining.
None of the cases look dangerous, so I rolled them back to the
non-snprintf versions.

Thanks,
- --
Greg Sabino Mullane greg-738XdyZ4GzZWk0Htik3J/[email protected]
End Point Corporation
PGP Key: 0x14964AC8 200801221922
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
-----BEGIN PGP SIGNATURE-----

iD8DBQFHloi7vJuQZxSWSsgRA9ztAJ9sneVTmPFAXoULm51G+Um45sebBACgv8uH
PIsQDMZDKLO7enbogeqatOQ=
=Dttq
-----END PGP SIGNATURE-----