RE: Any DBD::Pg Committers out there?

Here's the tiny patch for the test to work under Perl 5.12.

-- 
Eric Simon
The IQ Group, Inc.


-----Original Message-----
From: David E. Wheeler [mailto:[email protected]] 
Sent: Tuesday, November 16, 2010 5:05 PM
To: Eric Simon
Cc: [email protected]
Subject: Re: Any DBD::Pg Committers out there?

On Nov 16, 2010, at 3:01 PM, Eric Simon wrote:

> I also patched the 04misc test because it was failing under Perl 5.12.  If
> you'd like me to break that out into a separate patch, let me know.

Yeah, that'd be great.

As for the cancel bit:

* I can't speak to the implementation, as I don't know XS at all. Can anyone
else have a look at comment?

* Would you mind adding some tests for the new feature?

Thanks,

David

Index: t/04misc.t
===================================================================
--- t/04misc.t	(revision 14527)
+++ t/04misc.t	(working copy)
@@ -284,7 +284,7 @@
 
 $t='The "data_sources" method returns undef when fed a bogus second argument';
 @result = DBI->data_sources('Pg','foobar');
-is_deeply (@result, undef, $t);
+is (scalar @result, 0, $t);
 
 $t='The "data_sources" method returns information when fed a valid port as the second arg';
 my $port = $dbh->{pg_port};