Re: Quoting of values in arrays in broken in DBD::Pg, can you help fix it? ( CPAN RT#58552 ) [SumsaultRT #9386]

On Saturday, October 08, 2011 at 09:39:50 PM, Mark Stosberg wrote:


> My problem with Noah's patch is that it didn't find the new test that I
> added to the ticket.
> 
> https://rt.cpan.org/Ticket/Attacahment/973506/506656/
> 
> So, either my test is wrong, or Noah's patch is incomplete. Could you
> help confirm which is the case?
> 

$SQL = q{INSERT INTO dbd_pg_test (id,testarray2) VALUES };
                                     ^^^^^^^^^^
Should that be "testarray"?

And there might be something to be gained by not doing the sv_catpvn() one
byte at a time in the inner loop....

-r