Re: pgsql: pg_stat_activity: show NULL stmt start time for walsenders

Michael Paquier <[email protected]> Wed, 8 Jan 2020 10:58:44 +0900
Newsgroups gmane.comp.db.postgresql.devel.cvs
Message-ID <[email protected]>
--mrJd9p1Ce66CJMxE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi Alvaro,

On Tue, Jan 07, 2020 at 06:16:24PM -0300, Alvaro Herrera wrote:
> So I misidentified things; it's not commit be87b70b6117 (pg11) that put
> auxiliary processes in pg_stat_activity, but fc70a4b0df38 (pg10).  So I
> applied it back to pg10 also.  (I did verify that walsenders appear with
> a xact_time in pg_stat_activity in pg10 before this patch, and not
> afterwards.)
>=20
> We're still computing useless xact start timestamps in branches 9.4 -
> 9.6, but I don't think we care.  (If we do care, then we probably also
> care about xact *stop* time ... but meh.)

This commit has angered the buildfarm gods on HEAD and stable
branches, with failures in subscriptionCheck.
--
Michael

--mrJd9p1Ce66CJMxE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl4VN1QACgkQnvQgOdby
QH2Sow//cYyM0cAZ3M7FhDbJo3sQd0p+HwxRGS+5Yx2qYDGmEFf60lp9ti/wPLUF
4cUxIJRrF7iwEYjuqBNxPbijMBZUyNOv0Kx30svffYSYwrvUsNuTfOmQrqomukWw
anuIZ8HliP19jdz4tSNb7DTMNoHAQtEAK2haZX80LyQPdHK40e/IGYNEDW0rzeqU
9ituZgVRb2z3MynXzBBgfCiIV73mYEQV0t0z1zGGq55cjit7h3MR4x87otLQ3/CM
y8nWyLlecQMRsC/Ns+nSlTL58lRxZs1qsxQrH1T5tvWSGrjeS3USNNMleWMtQKZ9
sDheswXtNKgV2w27h0AkECDLfTgqq/6ZpEPzYpFZpF38yMXKcNyRE0h0PnlO2NBk
EMXwXjT0XGiFCUrLB5tqFXyQpBPNfLwR1DvWJ1TRwWvAlKwzXwy0zechGilexwgb
U5cErINLwuMYsOd6xZPpSckvFRG9ttHPafyUCWozBQdbv0ZYu7TQdn4/B6prHYQB
aYbfPnis/hBHMQbUw3s9oOZ5YDd5sJBoBN68kJ0OCN793KY/4d7/cYb2hsjkEdHk
QL+m9Z2inXNtHaa0tt0pe5lLD4LC8La70BYUoRYIaWlIrHH2YpFre2MsTXs43fp0
ENQCQPhPJqnacregfV4QLC3wJPiQM+4f2NParWy299S3WOaltE4=
=I3YZ
-----END PGP SIGNATURE-----

--mrJd9p1Ce66CJMxE--