Re: PostgreSQL 12 release notes missing breaking change in libpq

Michael Paquier <[email protected]> Wed, 30 Oct 2019 13:29:48 +0900

Newsgroups	gmane.comp.db.postgresql.devel.documentation
Message-ID	<[email protected]>

On Wed, Oct 23, 2019 at 10:05:44PM -0400, Bruce Momjian wrote:
> My reading of the commit message is that the error messages will just be
> more helpful now, not that some things would now error that use to be
> ignored.  I am still unclear exactly what the release notes should say.

Nay.  It could be worse as in some cases like for the keepalive
parameters, the values would be just silently ignored.  Please let me
suggest the attached for the release notes of REL_12_STABLE.
--
Michael

libpq-parsing-notes-12.patch (text/x-diff, 1 KB)

diff --git a/doc/src/sgml/release-12.sgml b/doc/src/sgml/release-12.sgml
index 126d6144a4..b7287196f3 100644
--- a/doc/src/sgml/release-12.sgml
+++ b/doc/src/sgml/release-12.sgml
@@ -654,6 +654,28 @@ Author: Peter Eisentraut <[email protected]>
      </para>
     </listitem>
 
+    <listitem>
+<!--
+Author: Michael Paquier <[email protected]>
+2018-09-12 [e7a221797] Parse more strictly integer parameters from connection s
+-->
+
+     <para>
+      Parse more strictly integer parameters from connection strings in libpq
+      (Fabien Coelho)
+     </para> 
+
+     <para>
+      In older versions, using an incorrect integer value in connection
+      parameters <literal>connect_timeout</literal>,
+      <literal>keepalives</literal>, <literal>keepalives_count</literal>,
+      <literal>keepalives_idle</literal>,
+      <literal>keepalives_interval</literal> and <literal>port</literal>
+      made libpq either ignore those values or fail with incorrect
+      error messages.
+     </para> 
+    </listitem>
+    
    </itemizedlist>
 
   </sect2>

signature.asc (application/pgp-signature, 833 B)