Re: wal_sender_timeout / wal_receiver_timeout - seconds or milliseconds?

Michael Paquier <[email protected]> Tue, 5 Nov 2019 13:27:16 +0900

Newsgroups	gmane.comp.db.postgresql.devel.documentation
Message-ID	<[email protected]>

On Mon, Nov 04, 2019 at 09:52:34PM -0500, Bruce Momjian wrote:
> The default _value_ is 60 seconds, and we use the 's' to specify
> seconds.  What the comment is saying is that if you _don't_ specify any
> units, the integer is in milliseconds.  I am not sure how to improve
> that.

I do have a suggestion as per the attached, say:
+#wal_sender_timeout = 60s      # in milliseconds if no unit specified;
+                               # 0 disables
--
Michael

pgconf-units.patch (text/x-diff, 1.1 KB)

diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample
index 0fc23e3a61..eea017e840 100644
--- a/src/backend/utils/misc/postgresql.conf.sample
+++ b/src/backend/utils/misc/postgresql.conf.sample
@@ -286,7 +286,8 @@
 #max_wal_senders = 10		# max number of walsender processes
 				# (change requires restart)
 #wal_keep_segments = 0		# in logfile segments; 0 disables
-#wal_sender_timeout = 60s	# in milliseconds; 0 disables
+#wal_sender_timeout = 60s	# in milliseconds if no unit specified;
+				# 0 disables
 
 #max_replication_slots = 10	# max number of replication slots
 				# (change requires restart)
@@ -326,7 +327,8 @@
 					# query conflicts
 #wal_receiver_timeout = 60s		# time that receiver waits for
 					# communication from master
-					# in milliseconds; 0 disables
+					# in milliseconds if no unit specified;
+					# 0 disables
 #wal_retrieve_retry_interval = 5s	# time to wait before retrying to
 					# retrieve WAL after a failed attempt
 #recovery_min_apply_delay = 0		# minimum delay for applying changes during recovery

signature.asc (application/pgp-signature, 833 B)