Re: Improve documentation about include_dir parameter.
Bruce Momjian <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.devel.documentation |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Apr 9, 2019 at 10:23:37AM -0300, Emanuel Araújo wrote: > Hi, > > when I choose conf files instead of postgresql.conf I needed uncomment > "include_dir" parameter in postgresql.conf to work fine. It is a exception > over defaults parameters in postgresql.conf. > > Documentation don't explain that. > > How can submit improve patch in documentation about that. I see your point. In every other case, when you see a setting and value in postgresql.conf, the value is the _default_. However in this case: #include_dir = 'conf.d' 'conf.d' is not the default, and you have to remove the comment to use 'conf.d' as a configuration directory. This is not mentioned in the docs. However, I think the problem is not the docs, but rather postgresql.conf.sample. The attached patch fixes this, and I assume it should be backpatched, based on previous discussions of backpatching this file. -- Bruce Momjian <[email protected]> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
config.diff
(text/x-diff, 849 B)
diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample index 77bb7c2402..0c905bb55d 100644 --- a/src/backend/utils/misc/postgresql.conf.sample +++ b/src/backend/utils/misc/postgresql.conf.sample @@ -739,10 +739,10 @@ # These options allow settings to be loaded from files other than the # default postgresql.conf. -#include_dir = 'conf.d' # include files ending in '.conf' from - # directory 'conf.d' -#include_if_exists = 'exists.conf' # include file only if it exists -#include = 'special.conf' # include file +#include_dir = '' # include files ending in '.conf' from + # a directory, e.g., 'conf.d' +#include_if_exists = '' # include file only if it exists +#include = '' # include file #------------------------------------------------------------------------------