Re: Docs for Generated Columns

On 5/23/19 5:50 PM, Tobias Bussmann wrote:
> while reading though the docs of the upcoming pg12 features, I
> stumbled upon some wording regarding generated columns: both in
> create_table.sgml [1] and create_foreign_table.sgml [2] the paragraph
> for the GENERATED ALWAYS AS clause is introduced with
>> This clause creates the column as a generated column. The column
>> cannot be written to, and when read it will be computed from the
>> specified expression.

> To me this sounds confusing, if not wrong. Till v8 of the patch were
> STORED and VIRTUAL generated columns were described afterwards this
> was less obvious but now with only STORED it sounds like a reference
> to the VIRTUAL variant.

No doubt this is flat out wrong.


> Not being I native english speaker I'm restrained to send a patch but
> may I suggest the following for discussion:

> The column cannot be written to, and when read the result of the
> specified expression will be returned.


That sounds reasonable to me.

Joe

-- 
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEg14x9eymXoJyHrH+N/L3QzX32GUFAlzn4eUACgkQN/L3QzX3
2GUVqQ/6A6mrfHNCZPGjV03Rx52u/fgA11QRj2cD9YlM++P+SfVAWlmuz3XYvUdR
FndcWLix4y1stM8uva9GfKRwPAgzdhn88AMEx3444sderOOm5/6ivVjioGahUkof
7WTaftrinfvb/idPe++oTGYHhov4jSGU0ccR031zKA7CIsIkf6jUFUskZxWvXt8v
qmF8SxjGcPQNt9HiS/Lf9PtEqLOWebfcnfesYWlMB89fTZvDy1OO/NDpFFKfNk97
8cBEise/c2XnvTsCSNHOuI5q7m9ozgdk9XH+K6apKQ5tioiqQl9Wqy2A+JSQj0zI
/9O9mw51b/wB9Q2pkAjnxqjdiGFqVHskEVmNdMiMwkeXQHg+hPf8TxjPLJTqXxLv
w3XBprtPzahgT8RA3JjS7R+7YmGcK3nPyahlTo3nFRSijsvQVYzqMleLJ98E0jSH
FxEOTJ3J7C/fgLnqyQ8Q5JVSFCs3ZBKM0L3MaTD5iAu1T8QoiYUZwI9DcSkZOd7Z
+TTfSNU1yK9+DOLqzOsLRkPfYHHkMU63MuSQfcAKimfrj0wJ/+mXAjJpmWJwcZ1R
rcnDZoohb/sHhBlHedZ7IwYFWk3Q6MZj7QwHFpbwYGuzwYsUTYkJ7OmJdl3K5jfk
QtZvSVyxxwjjK+EzSglnlVcBmRSITefQAaj7Sfn0bgwptN1+75w=
=4W7O
-----END PGP SIGNATURE-----