Re: SPITupleTable members missing in docs

Fabien COELHO <[email protected]>
Newsgroups gmane.comp.db.postgresql.devel.documentation
Message-ID <alpine.DEB.2.21.1907121748290.8895@lancre>
Hello,

>> To take into account Tom's comment, I'd suggest a middle ground by 
>> commenting a public and private part explicitely in the struct,
>>    typedef struct {
>>      /* PUBLIC members to be used by callers ... */
>>      /* PRIVATE members, not intended for external usage ... */
>>    } ... ;
>
> One problem is that the members we've retroactively decided are "public"
> are in the middle of the struct :-(.

Argh, I did not notice this tiny but relevant detail.

> But it occurs to me that there's no good reason we couldn't re-order the
> members, as long as we only do so on HEAD and not in released versions.
> That would make it a bit less inconsistent and easier to add labels
> such as you suggest.

Indeed. SPI-dependent extensions are likely recompiled between major 
version, so a reordering should not cause significant problems.

This mean that a simple doc patch is turned into a code patch.

-- 
Fabien.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.