Re: Add support for automatically updating Unicode derived files
John Naylor <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.devel.general |
|---|---|
| Message-ID | <CACPNZCujxKdKFOm89iA8wzzYwZe-b6fHLWNGcix7WaCsYKa6uA@mail.gmail.com> |
On Thu, Dec 26, 2019 at 12:39 PM Peter Eisentraut <[email protected]> wrote: > > On 2019-12-19 23:48, John Naylor wrote: > > I would print out the full boilerplate like for other generated headers. > > Hmm, you are probably comparing with > src/common/unicode/generate-unicode_norm_table.pl, but other file > generating scripts around the tree print out a small header in the style > that I have. I'd rather adjust the output of > generate-unicode_norm_table.pl to match those. (It's also not quite > correct to make copyright claims about automatically generated output.) Hmm, the scripts I'm most familiar with have full headers. Your point about copyright makes sense, and using smaller file headers would aid readability of the scripts, but I also see how others may feel differently. v2 looks good to me, marked ready for committer. -- John Naylor https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services