Re: pgsql: Add basic TAP tests for psql's tab-completion logic.

On Sat, Jan 4, 2020 at 12:56 PM Tom Lane <[email protected]> wrote:
> Yeah, there is still something unexplained about that.  We've so far
> failed to pin the blame on either readline version or environment
> settings ... but what else could be causing you to get different
> results?

Beats me. Could have something to do with the fact that my libtinfo5
is in fact a patched version -- "6.1-1ubuntu1.18.04". (Whatever that
means.)

> For the record, I'm currently running around and trying the attached
> (on top of latest HEAD, 60ab7c80b) on the various configurations
> I have here.  Could you confirm that it works, or doesn't, in your
> environment --- and if it doesn't, what's the output?

This patch shows the same old failure as before:

cd /code/postgresql/patch/build/../source/src/bin/psql &&
TESTDIR='/code/postgresql/patch/build/src/bin/psql'
PATH="/code/postgresql/patch/build/tmp_install/code/postgresql/patch/install/bin:$PATH"
LD_LIBRARY_PATH="/code/postgresql/patch/build/tmp_install/code/postgresql/patch/install/lib"
 PGPORT='65432'
PG_REGRESS='/code/postgresql/patch/build/src/bin/psql/../../../src/test/regress/pg_regress'
REGRESS_SHLIB='/code/postgresql/patch/build/src/test/regress/regress.so'
/usr/bin/prove -I
/code/postgresql/patch/build/../source/src/test/perl/ -I
/code/postgresql/patch/build/../source/src/bin/psql  t/*.pl
t/010_tab_completion.pl .. 8/?
#   Failed test 'offer multiple table choices'
#   at t/010_tab_completion.pl line 112.
# Actual output was "\r\n\e[01;35mmytab\e[0m\e[K123\e[0m\e[K
\e[01;35mmytab\e[0m\e[K246\e[0m\e[K  \r\npostgres=# select * from
mytab\r\n\e[01;35mmytab\e[0m\e[K123\e[0m\e[K
\e[01;35mmytab\e[0m\e[K246\e[0m\e[K  \r\npostgres=# select * from
mytab"
#
# Looks like you failed 1 test of 12.
t/010_tab_completion.pl .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/12 subtests

Test Summary Report
-------------------
t/010_tab_completion.pl (Wstat: 256 Tests: 12 Failed: 1)
  Failed test:  8
  Non-zero exit status: 1
Files=1, Tests=12,  7 wallclock secs ( 0.01 usr  0.00 sys +  0.37 cusr
 0.09 csys =  0.47 CPU)
Result: FAIL
Makefile:87: recipe for target 'check' failed
make: *** [check] Error 1

-- 
Peter Geoghegan