Re: remove some STATUS_* symbols
Michael Paquier <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.devel.general |
|---|---|
| Message-ID | <[email protected]> |
On Sun, Dec 29, 2019 at 11:33:34AM +0100, Peter Eisentraut wrote: > Attached are two patches to remove these two symbols. STATUS_FOUND can be > replaced by a simple bool. STATUS_WAITING is replaced by a separate enum. Patch 0001 looks good to me, but I got to wonder why the check after waitMask in LockAcquireExtended() is not done directly in LockCheckConflicts(). Regarding patch 0002, I am not sure that the addition of ProcWaitStatus brings much though in terms of code readability. -- Michael
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl4S1F8ACgkQnvQgOdby QH3u3xAAi7MLSMUR0/wUuLFmTYHwE3w460YZbArdu4jYhouAIq+bx2sZ8LDm6TUW PQHh2K/d0kX1AhHQQXJ9As2ar6UGr1rMcnCyCQTfOibjF568qPL4qrN5FQCEyfjs L2pMoU0T3bGfKRys22wRNy/tuAmdvQC4cSS76+dyIknXdgoIyRXuHqqk3GF8ID4u nuH5wigzGLioiKoxknAkAQLXbCRNsJJR/GkZGFJLlon90GE9ekGksi1m0QjNAJ8B R0GQie/SsnEgJ7GlT1LKV5fGQYswdaVi5CL5yeOtsA85sM/mxu9KWqGCri7+C0T6 qPLdX0MTw1RhBDak2NOlFobl06WsUjnGd0iDntjXNQNuxbY/uqoIRhPiBwqRN4De d2WaqYV82M+PuY4WMNm2Klo5H3JlTjxMnmbspdbfi/BJLybhSZlpZ+xSr3+EZy8S /ao9rTtgmrGWzm+lU39CxNCkI6bq6tUjjKDeu5XTT0nys/nCKjssE3OXX/uEWr1V uoi65EaopDVRDChn2ycSAyAVwgsBbymF6TloHSdwKnydJUtOVJdeianySPJPR6jn Bu0QV4TkXxml8hEVH0MvtM99C/sWmX7c3sCeVS0FCvEO0LOJxKY18wQNoI2/A0qM ZGSDQahOT6pqdqa8krT5OLrATTJO2H6g/GSR17WTRfm6Jsmh0tk= =nO6A -----END PGP SIGNATURE-----