Re: Remove libpq.rc, use win32ver.rc for libpq

On Fri, Dec 27, 2019 at 05:25:58PM +0100, Peter Eisentraut wrote:
> I was wondering why we have a separate libpq.rc for libpq and use
> win32ver.rc for all other components.  I suspect this is also a leftover
> from the now-removed client-only Windows build.  With a bit of tweaking we
> can use win32ver.rc for libpq as well and remove a bit of duplicative code.
> 
> I have tested this patch with MSVC and MinGW.

The patch does not apply anymore because of two conflicts with the
copyright dates, could you rebase it?  Reading through it, the change
looks sensible.  However I have not looked at it yet in details.

- FILEFLAGSMASK  0x17L
+ FILEFLAGSMASK  VS_FFI_FILEFLAGSMASK
Are you sure with the mapping here?  I would have thought that
VS_FF_DEBUG is not necessary when using release-quality builds, which
is something that can be configured with build.pl, and that it would
be better to not enforce VS_FF_PRERELEASE all the time.
--
Michael

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl4S6XkACgkQnvQgOdby
QH0htxAAi4trUoXuksWvBWAMRY2eaCsm1dexWFaUz/KzmM+5GTgbqcoe6+guVvnY
atD001ruu5AIzqZigjcW8l/NhlI19lW6bUC0+c3SH4wUiHi13ef2PDj78UTvhwvs
NmvLagn49QtWAXDeoK7cgnpTFF5IEzxA1rr4XaqsNw/J4ttN6gP4YqbmwLk7DTlx
CgV5f6EE07Z/O4WfxvTGfwe/+xaSVxCcVMXAZnn7x7IZnRZj2aSINnoStBrjaqe5
w7dCkXWadv3KnGEnevHuqrPwRHkjTlbID1/UnjmFOjINFZsL/50lDmpRTqq2rYO8
3NSUjlYSwbzA7TK0Yi/7xM/NCgUprCGaOQjiA6/MfsaLXp5+IrARIejhHp8q4V7E
6s5uDqIRenZMvh0Y8t0fZJIdg4xV/rSO4qjjHcup/bMv7GovAWymaBwNafqCUrtF
eqYqCk/FN/W+Qcp67B0O5IfB86YmwWeqYHuTuso6eKe1uOzKeH1v1nAr7SB34gDp
1EhldkN4lBgaxFSwNVOv9wWyn10ox1QEH1KaxzRMVosCR7J4npeZBJfVuV6e290r
3jr68v/73scZ1ejpB0q4PLe63H0ltWIZlRUrsPbhsyfvf6HYUvTQz6rBuKfTNAy7
JPSEtRLd43J6KAmzg3NmP6Xwe12XwEdYaMm9bf6b3IvFzQ7uFrI=
=BViv
-----END PGP SIGNATURE-----