Re: [PATCH] fix a performance issue with multiple logical-decoding walsenders
Tom Lane <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.devel.general |
|---|---|
| Message-ID | <[email protected]> |
Julien Rouhaud <[email protected]> writes: > On Mon, Jan 6, 2020 at 7:57 PM Pierre Ducroquet <[email protected]> wrote: >> My deepest apologies for the patch being broken, I messed up when transferring >> it between my computers after altering the comments. The verbatim one attached >> to this email applies with no issue on current HEAD. >> The patch regarding PostmasterIsAlive is completely pointless since v12 where >> the function was rewritten, and was included only to help reproduce the issue >> on older versions. Back-patching the walsender patch further than v12 would >> imply back-patching all the machinery introduced for PostmasterIsAlive >> (9f09529952) or another intrusive change there, a too big risk indeed. > +1, backpatch to v12 looks sensible. Pushed with some minor cosmetic fiddling. regards, tom lane