Re: [PATCH] Atomic pgrename on Windows
Tom Lane <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.devel.general |
|---|---|
| Message-ID | <[email protected]> |
Alexander Korotkov <[email protected]> writes: > On Tue, Jan 7, 2020 at 7:16 PM Tomas Vondra > <[email protected]> wrote: >> I don't have access to a Windows machine and my developer experience >> with that platform is pretty much nil, but I think this patch makes >> sense. It's not an ideal solution, but it's not clear such solution >> exists, and an improvement is better than nothing. > Thank you for your attention to this patch! FWIW, I don't like this patch much at all. I too know nothing about Windows, but I do *not* like inventing a distinction between "rename" and "rename_temp" and expecting all call sites to have to decide which one to use. That's allowing a single platform's implementation bugs to dictate our APIs globally; plus it's not clear that every call site can know which is more appropriate. regards, tom lane