Re: jsonb_set() strictness considered harmful to data
Andrew Dunstan <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.devel.general,gmane.comp.db.postgresql.general |
|---|---|
| Message-ID | <CAA8=A78Wwr-kqn8gBZRArM9Nj2j-+yu1UOsTfDrah2O=ZkunoQ@mail.gmail.com> |
On Wed, Jan 8, 2020 at 7:08 AM Pavel Stehule <[email protected]> wrote: > > Hi > > po 6. 1. 2020 v 22:34 odesílatel Andrew Dunstan <[email protected]> napsal: >> >> >> Updated version including docco and better error message. >> >> cheers >> >> andrew > > > I think so my objections are solved. I have small objection > > + errdetail("exception raised due to \"null_value_treatment := 'raise_exception'\""), > + errhint("to avoid, either change the null_value_treatment argument or ensure that an SQL NULL is not used"))); > > "null_value_treatment := 'raise_exception'\"" > > it use proprietary PostgreSQL syntax for named parameters. Better to use ANSI/SQL syntax > > "null_value_treatment => 'raise_exception'\"" > > It is fixed in attached patch > > source compilation without warnings, > compilation docs without warnings > check-world passed without any problems > > I'll mark this patch as ready for commiter > > Thank you for your work > Thanks for the review. I propose to commit this shortly. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services