Fixing parallel make of libpq

[email protected] (Dagfinn Ilmari Mannsåker)
Newsgroups gmane.comp.db.postgresql.devel.general
Message-ID <[email protected]>
Hi hackers,

I noticed to my annoyance that 'make -j4 -C src/interfaces/libpq'
doesn't work in a clean checkout, because it can't find
libpgcommon_shlib and libpgport_shlib.  It looks like that's because the
submake-libpgport dependency is declared on the all-lib target, not on
the shlib itself.  Moving it to SHLIB_PREREQS instead fixes it, patch
for which is attached.

- ilmari
-- 
- Twitter seems more influential [than blogs] in the 'gets reported in
  the mainstream press' sense at least.               - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
  to a mainstream media article.                      - Calle Dybedahl
0001-Make-libpgport-a-dependency-of-the-libpq-shlib-itsel.patch (text/x-diff, 840 B)
From 08296fc98aafdaa60045275d592bbe0a364311c9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Dagfinn=20Ilmari=20Manns=C3=A5ker?= <[email protected]>
Date: Wed, 8 Jan 2020 13:20:13 +0000
Subject: [PATCH] Make libpgport a dependency of the libpq shlib itself, not
 the all-lib

This fixes parallel make of libpq in clean source directory.
---
 src/interfaces/libpq/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/interfaces/libpq/Makefile b/src/interfaces/libpq/Makefile
index 773ef2723d..2511d6f771 100644
--- a/src/interfaces/libpq/Makefile
+++ b/src/interfaces/libpq/Makefile
@@ -94,9 +94,9 @@ endif
 
 SHLIB_EXPORTS = exports.txt
 
-all: all-lib
+SHLIB_PREREQS = submake-libpgport
 
-all-lib: | submake-libpgport
+all: all-lib
 
 # Shared library stuff
 include $(top_srcdir)/src/Makefile.shlib
-- 
2.20.1
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.