Re: Questions/Observations related to Gist vacuum

Mahendra Singh Thalor <[email protected]>
Newsgroups gmane.comp.db.postgresql.devel.general
Message-ID <CAKYtNAoTDsc+Dgn2+A35v-YKt9qtXcjNMRhUo-3k8=UoAmwL+A@mail.gmail.com>
On Mon, 9 Dec 2019 at 14:37, Amit Kapila <[email protected]> wrote:
>
> On Mon, Dec 9, 2019 at 2:27 PM Amit Kapila <[email protected]>
wrote:
> >
> > I have modified the patch for the above points and additionally ran
> > pgindent.  Let me know what you think about the attached patch?
> >
>
> A new version with a slightly modified commit message.

I reviewed v4 patch and below is the one review comment:

+     * These are used to memorize all internal and empty leaf pages. They
are
+     * used for deleting all the empty pages.
      */
After dot, there should be 2 spaces. Earlier, there was 2 spaces.

Other than that patch looks fine to me.

-- 
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.