Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Peter Eisentraut <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.devel.general |
|---|---|
| Organization | 2ndQuadrant |
| Message-ID | <[email protected]> |
On 2020-01-09 16:50, Tom Lane wrote: > Christoph Berg <[email protected]> writes: >> Fwiw if libedit in xenial is Just Broken and fixing the tests would >> just codify the brokenness without adding any value, I'll just disable >> that test in that particular build. It looks like setting >> with_readline=no on the make command line should work. > > That would disable psql's tab completion, command editing, and history > altogether, which I doubt is what you want for production builds. > If we conclude we can't work around the testing issues for ancient > libedit, probably the right answer is to provide a switch to > disable just the test. I've been trying to dance around that > conclusion, but maybe we should just do it and move on. I think he means something like make check with_readline=no not for the actual build. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services