Re: pgbench - use pg logging capabilities
Michael Paquier <[email protected]> Fri, 10 Jan 2020 09:45:46 +0900
| Newsgroups | gmane.comp.db.postgresql.devel.general |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Jan 09, 2020 at 09:27:42PM -0300, Alvaro Herrera wrote:
> On 2020-Jan-09, Fabien COELHO wrote:
>> - if (unlikely(__pg_log_level <= PG_LOG_DEBUG))
>> + if (pg_log_debug_level)
>> {
>
> Umm ... I find the original exceedingly ugly, but the new line is
> totally impenetrable.
Maybe just a pg_logging_get_level() for consistency with the
_set_level() one, and then compare the returned result with
PG_LOG_DEBUG in pgbench?
--
Michael
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl4XyToACgkQnvQgOdby QH2aSw//bJLLPE2xkMYVu0t1YjyTztg3Dg7o3tKEOvjwbkNFMFTqpp5k57/SuTFi K0eOabwb1WlNkD3+p4tq6R4W/3CDIpC+XoabiQiJ2UvEodCPYHWsl510Im7iYW/v /MS2VuWAKb6H6OcUCfXchziSmWLHjNly5qCejPI3UqIJ9zo1Q0p0TW0NxwQSuqHt J7/3BhmnqP2ZStg0RhlNRpqVAt+H1NK2/GHG5TWPMMP9oXrNSN7ozQlAmqHs9sCF rKZA5Jy4YNtUlMDrrFewFHy1szzUKA3v7M2DUvO9KTGSNNMO2JzmMUKtfSkgsXPs Pt9/7RI106/gOZLGmafmdnQlMf76WICgPDc0nvYPc0z/eTt67N1GwGJmbh5P38/5 roAx2j1pJ6Im+VOUx1lzET7sSl5YkMpP1PCGiVF4fF/vPGOLlsId6gUE03YxcRds +KZphx7oMqGMvRhKa1wtIkAqY3rNpTTz++lWXJyesufja1lK0lFnm5PZ40dFpv8W qcFLrDs2FmjOO/iiZy6EWOFBVZXk0FM4ZF3Sbhy/G+BYTgjYZtEnBxtd96GKdQH3 l8XWYIkoUYZcLZSbfcSCKDn7pQGAp6qWaJG8gTISPk98PG2/GuycE90tvLMJMiYq A/WrZ1oeXOlh7lor4FGgGUm1A4TpzW46f4ql0g57qICm58dlr0Q= =xkLq -----END PGP SIGNATURE-----