Re: Add FOREIGN to ALTER TABLE in pg_dump
Tomas Vondra <[email protected]> Sat, 11 Jan 2020 02:52:53 +0100
| Newsgroups | gmane.comp.db.postgresql.devel.general |
|---|---|
| Message-ID | <20200111015253.q6q6h4rpp37qitiv@development> |
Hi, On Thu, Sep 26, 2019 at 01:47:28PM +0000, Luis Carril wrote: > >I don't disagree with adding FOREIGN, though. > >Your patch is failing the pg_dump TAP tests. Please use >configure --enable-tap-tests, fix the problems, then resubmit. > >Fixed, I've attached a new version. > This seems like a fairly small and non-controversial patch (I agree with Alvaro that having the optional FOREIGN seems won't hurt). So barring objections I'll polish it a bit and push sometime next week. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services