Re: Questions/Observations related to Gist vacuum
Dilip Kumar <[email protected]> Mon, 13 Jan 2020 08:55:57 +0530
| Newsgroups | gmane.comp.db.postgresql.devel.general |
|---|---|
| Message-ID | <CAFiTN-vXVG3gthLWy0RNBcdXhBkb7FS91qktAsPJr00UyGwE9A@mail.gmail.com> |
On Thu, Jan 9, 2020 at 4:41 PM Mahendra Singh Thalor <[email protected]> wrote: > > On Mon, 9 Dec 2019 at 14:37, Amit Kapila <[email protected]> wrote: > > > > On Mon, Dec 9, 2019 at 2:27 PM Amit Kapila <[email protected]> wrote: > > > > > > I have modified the patch for the above points and additionally ran > > > pgindent. Let me know what you think about the attached patch? > > > > > > > A new version with a slightly modified commit message. > > I reviewed v4 patch and below is the one review comment: > > + * These are used to memorize all internal and empty leaf pages. They are > + * used for deleting all the empty pages. > */ > After dot, there should be 2 spaces. Earlier, there was 2 spaces. > > Other than that patch looks fine to me. > Thanks for the comment. Amit has already taken care of this before pushing it. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com