Re: isTempNamespaceInUse() is incorrect with its handling of MyBackendId

Michael Paquier <[email protected]> Tue, 14 Jan 2020 07:23:19 +0900
Newsgroups gmane.comp.db.postgresql.devel.general
Message-ID <[email protected]>
On Mon, Jan 13, 2020 at 02:56:13PM +0100, Julien Rouhaud wrote:
> Well, since isTempNamespaceInUse is for now only called by autovacuum, and
> shouldn't change soon, this really feels premature optimzation, so your
> original approach looks better.

Yes, I'd rather keep this routine in its simplest shape for now.  If
the optimization makes sense, though in most cases it won't because it
just helps sessions to detect faster their own temp schema, then let's
do it.  I'll let this patch aside for a couple of days to let others
comment on it, and if there are no objections, I'll commit the fix.
Thanks for the lookup!
--
Michael
signature.asc (application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl4c7dcACgkQnvQgOdby
QH1Uvw/9HWrXganUk421aIy/11VljvX3EPsGbZhe2gHKCK7nehG+cXAZSyfmL92y
0JbzOUj9pr4TxiQ9cEJxNMVZs5wi1+HPuSXi6m/v71AsYkCW0EIj3Edy2glbBK6h
fRKYBzNlZsxmQpNFhrQeEPD6FS5QWwjJjo8sDHom+v7/vsZ/LTTobQSLxpwTqbTc
5QqQiLGOoGsNNgf9aqINBK1oVweb9JnmWHU1AxGhVu949eXFy46aDHDDPCLfJUnC
5as3Yw5p5LAqzF+P0lNBb1HZlOcmBV7zBItPG3Url7I+V/RcBeLMtPknNFGWC4ss
0nJORPkQwpZXAufYThs7RNouvx0r3+f6kIrtUW3UKRVBvA7SIW3Ah8K9aYP5d6ZV
kXTraQvl2tV7Qftgh4hNinQKbmsouRY6iC+mraXNtRFGWVLPQV+SoWAQGYrWROnX
3+p/Bh1vW6Lp2/VsfNKyKBYQJHMiQxh9aLtzg1fIk8N6psaa7EXWsgVWv+EGYeFf
Hw3j89k6yJub984ibrj6xsLjIQvEbMFGpmcc3LvmgehyfANZnC2YrtKNcbh/AaS2
+cwdQUNDJQ0Sz/bSm7wJkJ8syMbhJMqtqPr5LT/0KN/cFszuf/6lJ/CsLnJC4q4q
xSpGTY5lDsTDWDQ4edaNxUkCY8/gte3rIxfjK3uo6uAOdwbp/P0=
=x5in
-----END PGP SIGNATURE-----