Re: Add FOREIGN to ALTER TABLE in pg_dump

vignesh C <[email protected]> Tue, 14 Jan 2020 06:02:56 +0530
Newsgroups gmane.comp.db.postgresql.devel.general
Message-ID <CALDaNm0CQ5ASGSnipH-rnPg3W1zYzX+V7tK3DXexCd_7it+W6Q@mail.gmail.com>
On Mon, Jan 13, 2020 at 7:52 PM Tom Lane <[email protected]> wrote:
>
> vignesh C <[email protected]> writes:
> > On Thu, Sep 26, 2019 at 7:17 PM Luis Carril <[email protected]> wrote:
> >>> Your patch is failing the pg_dump TAP tests.  Please use
> >>> configure --enable-tap-tests, fix the problems, then resubmit.
>
> >> Fixed, I've attached a new version.
>
> > Will it be possible to add a test case for this, can we validate by
> > adding one test?
>
> Isn't the change in the TAP test output sufficient?
>

I could not see any expected file output changes in the patch. Should
we modify the existing test to validate this.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com