Re: Add pg_file_sync() to adminpack
Michael Paquier <[email protected]> Tue, 14 Jan 2020 15:17:56 +0900
| Newsgroups | gmane.comp.db.postgresql.devel.general |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Jan 13, 2020 at 03:39:32PM +0100, Julien Rouhaud wrote: > Actually, can't it create a security hazard, for instance if you call > pg_file_sync() on a heap file and the calls errors out, since it's > bypassing data_sync_retry? Are you mistaking security with durability here? By default, the function proposed is only executable by a superuser, so that's not really a security concern.. But I agree that failing to detect a PANIC on a fsync for a sensitive Postgres file could lead to corruptions. That's why we PANIC these days. -- Michael
signature.asc
(application/pgp-signature, 833 B)
-----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl4dXRMACgkQnvQgOdby QH11Zw//R80drTsp0odhuVwn7wHRkcDgkSqxFSLqby0eJ66HUtIxAzstWvzfIZqn NtuVdHQ+x/svJEOiW8Fbe3m+Nx7q9H1/nYJMwHCw93a8zMnhdISMRX6fQ4YdxlZV TV62P6EgUNRZ1jzPxpvtJUGDQE9jrKhmUIqUq8rVxAlE8yPv7y/EjtV8qgPNORad dtJfvQIlCieNn82AJg8deuj+HYZpUAXmQFcOWmCTcoGOJWEt/dODw/AYTcyCB6Ma HtY4TzWZwDiPs5SzO2LVkuoyToR6fWrVCQNDuLjB+24AJL4CXOq1W2j5J6saGxQ2 BFuB3+jnopQdJUFPw6qEt7BxEeX8T8f5yQwODVGso+Od3bT6D/Kms2PZjvpeIjVX BQDmunZPQCXju0y7bVoWd1alucMEN1TBmmoXfjKAP7x5D3yKEz4L05verBGT1jPE e7nkRZ/qVAX7rpvvawUJjx8n4xjBV9njuy7fcnjePTOvwTaI593J4K5VdPBqGCEC c/2/Y+kORxZLxg3C0LAbRP3WutCm3SsJXU1A+34xT/4hiDBI8dDIdAjB1Ec/h2Lb vy6EJ4X6LsCeAqBqJ6BReV9qGyyES2MLzjNAtb2pG1Pn+FfSNDsM5blrpHGP0pq5 7I/OBvxsDJfQSCidaSwWHqIgZaJi/BZ6It9PO5S/FTDgvVTRutY= =cAJn -----END PGP SIGNATURE-----