Re: Remove libpq.rc, use win32ver.rc for libpq

--NJSRbAqOy4NeGDns
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 15, 2020 at 02:22:45PM +0900, Kyotaro Horiguchi wrote:
> At Tue, 14 Jan 2020 22:34:10 +0100, Peter Eisentraut <peter.eisentraut@2n=
dquadrant.com> wrote in=20
>> On 2020-01-09 10:56, Peter Eisentraut wrote:
>>> Note that there is FILEFLAGSMASK and FILEFLAGS.  The first is just a
>>> mask that says which bits in the second are valid.  Since both
>>> libpq.rc
>>> and win32ver.rc use FILEFLAGS 0, it doesn't matter what we set
>>> FILEFLAGSMASK to.  But currently libpq.rc uses 0x3fL and win32ver.rc
>>> uses 0x17L, so in order to unify this sensibly I looked for a
>>> well-recognized standard value, which led to VS_FFI_FILEFLAGSMASK.

Hmm.  I agree that what you have here is sensible.  I am wondering if
it would be better to have VS_FF_DEBUG set dynamically in FILEFLAGS in
the future though.  But that's no material for this patch.

>> Here is a rebased patch.
>=20
> It applied on 4d8a8d0c73 cleanly and built successfully by VS2019.

I have been testing and checking the patch a bit more seriously, and
the information gets generated correctly for dlls and exe files.  The
rest of the changes look fine to me.  For src/makefiles/Makefile.win32,
I don't have a MinGW environment at hand so I have not directly
tested but the logic looks fine.
--
Michael

--NJSRbAqOy4NeGDns
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl4etNYACgkQnvQgOdby
QH2yZg//cSLHhJQ2epA8dqhLWcH8wAtwBdp5zpJq+llfnM3BXos3+BWudMgxmI8w
+z1hk9fhfbXic6mKRQDhYXkm7O70wvG9+YA0utVOBWtPa54wejPUhxjka4GurZoE
5ZKk/1SRYwAPQNHDMRlFCCjsV/xYnORkqqfy7SofuhNOYo5dki4T+ccs/RfXdiTq
OOWqYq2gq34Gj/T2pjowvn7O9geBe+utoTxE03r8YEowh7g7ohTomra2d+5eKl1P
9hOlt58/AWP6rDwpJx4cUuq84pglVCyhF4BM5/kR/jjayGDCGv2o8A5ZZl21I3Vx
B7RFZl4qBOT7pFQiwXqP3OAVZqI8K6LKkamI9WNP9iA5tNFTnaE8KY6o+wUrO3Ck
jupcHWIwgTvnVqUvb550+IszwenPwj6UJznJBT6h2zUkM5mnmRnQvb/3pN9IIY52
tb6Ewm2UWw6NA/LFG0jehUcPDJCOIiPa++ajRNVwx3omU2Hu4Bc+eBBe8FlDV+VV
qVVSqdUyJmsmhsmAW396cmswlSvocRb5vDYbM6Td47TQfHk6jr+bB9pBE5FcYm9n
qlixBHUuTlOeH5Wj/xO+pNusg4EgIcVY3qt7itjIl/ANofQ2m4YscrmLJ3iZICqH
/QrF+DKvlad8T+pu0rnyfmo1TmB/hxm++bUqkf/eSKHRlj3sqsg=
=X18Y
-----END PGP SIGNATURE-----

--NJSRbAqOy4NeGDns--