Re: Simplify formatting.c
Tom Lane <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.devel.patches |
|---|---|
| Message-ID | <[email protected]> |
Bruce Momjian <[email protected]> writes: > Now that upper/lower/initcase do not modify the passed string, I have > simplified formatting.c with the attached patch. I was thinking the same thing while reading the patch. But please, make str_toupper() and friends declare their argument "const" if you're going to do this. Another issue in this area is that these functions could do with some refactoring to eliminate useless text/cstring conversions; I'm pretty sure some code paths are doing cstring->text->cstring in direct succession. Also, it seems a bit inconsistent to be relying on oracle_compat.c for upper/lower but not initcap. regards, tom lane -- Sent via pgsql-patches mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches