Re: libpq object hooks (libpq events)
"Merlin Moncure" <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.devel.patches |
|---|---|
| Message-ID | <[email protected]> |
On Mon, May 19, 2008 at 10:37 PM, Tom Lane <[email protected]> wrote: > Andrew Chernow <[email protected]> writes: >> 4. add a setter for result instance data >> - There should also be a PQsetInstanceData(PGconn*, ...) >> - I see no need for a passThrough setter > > Check, though I assume we're not expecting PQsetInstanceData to > propagate to previously created PGresults? > >> 5. move callback stuff to its own header, maybe pgcallback.h? > > Should be libpq-something. I was considering libpq-hooks.h or > libpq-events.h, but libpq-callback.h would be OK too. I think 'events' best describes what is going on. Your other suggestions are improvements (we maybe tried a little too hard to minimize exports). Losing the global hooks is no problem (it was basically syntax sugar). merlin -- Sent via pgsql-patches mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches