Re: Simplify formatting.c
Tom Lane <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.devel.patches |
|---|---|
| Message-ID | <[email protected]> |
Bruce Momjian <[email protected]> writes: > Tom Lane wrote: >> I'd say not. Can't we do some more refactoring and avoid so many >> useless conversions? Seems like str_initcap is the wrong primitive API >> --- the work ought to be done by a function that takes a char pointer >> and a length. That would be a suitable basis for functions operating >> on both text datums and C strings. > Yea, I thought about that idea too but it is going to add a strlen() > calls in some places, but not in critical ones. Sure, but the cost-per-byte of the strlen should be a good bit less than the cost-per-byte of the actual conversion, so that doesn't bother me too much. Actually it seems like the hard part is not so much the input representation as the output representation --- what should the base-level initcap routine return, to be reasonably efficient for both cases? regards, tom lane -- Sent via pgsql-patches mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches