Re: Simplify formatting.c
Bruce Momjian <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.devel.patches |
|---|---|
| Message-ID | <[email protected]> |
Euler Taveira de Oliveira wrote: > Tom Lane wrote: > > > Also, it seems a bit inconsistent to be relying on > > oracle_compat.c for upper/lower but not initcap. > > > I saw this inconsistence while I'm doing the patch. What about moving > that upper/lower/initcap and wcs* code to another file. pg_locale.c? > BTW, formatting.c and oracle_compat.c already include pg_locale.h. I researched this idea but is seems pg_locale.c contains only locale-specific stuff, while these functions have locale and non-locale versions; I ended up moving the common stuff into formatting.c. -- Bruce Momjian <[email protected]> http://momjian.us EnterpriseDB http://enterprisedb.com + If your life is a hard drive, Christ can be your backup. + -- Sent via pgsql-patches mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-patches