Re: [PATCHES] Extending grant insert on tables to sequences

Jaime Casanova escribió:
> On Thu, May 22, 2008 at 1:18 PM, Jaime Casanova <[email protected]> wrote:
> > Hi,
> >
> > The idea of this patch is to avoid the need to make explicit grants on
> > sequences owned by tables.
> 
> I've noted that the patch i attached is an older version that doesn't
> compile because of a typo...
> Re-attaching right patch and fix documentation to indicate the new behaviour...

I had a look at this patch and it looks good.  The only thing that's not
clear to me is whether we have agreed we want this to be the default
behavior?

A quibble:

> + 		foreach(cell, istmt.objects)
> + 		{
> + 			[...]
> + 
> + 			istmt_seq.objects = getOwnedSequences(lfirst_oid(cell));
> + 			if (istmt_seq.objects != NIL)
> + 			{
> + 				if (istmt.privileges & (ACL_INSERT)) 
> + 					istmt_seq.privileges |= ACL_USAGE;
> + 				else if (istmt.privileges & (ACL_UPDATE)) 
> + 					istmt_seq.privileges |= ACL_UPDATE;
> + 				else if (istmt.privileges & (ACL_SELECT)) 
> + 					istmt_seq.privileges |= ACL_SELECT;
> + 
> + 				ExecGrantStmt_oids(&istmt_seq);
> + 			}

Wouldn't it be clearer to build a list with all the sequences owned by
the tables in istmt.objects, and then call ExecGrantStmt_oids() a single
time with the big list?

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers