Re: variadic function support

On Thu, 2008-06-26 at 17:03 +0200, Pavel Stehule wrote:
> this is third variant with variadic argumen as scalar. But I still
> strongly prefer second variant with conformance declared variadic
> array with used array variable.

This version allows you to declare two functions "foo(variadic numeric)"
and "foo(numeric)", and then if you do a "\df foo" the backend crashes. 

Also, you didn't update an error string:

"variadic argument isn't an array" should (in this version) be something
like: "can't find array type for variadic parameter type %s"

I suggest a slightly different wording for the following error messages:

"aggregate function has variadic argument" -> "variadic parameters not
supported for aggregate functions"

and

"variadic argument isn't last function's argument" -> "variadic
parameter must be the last parameter to the function"

Those are just suggested wordings.

Regards,
	Jeff Davis


-- 
Sent via pgsql-patches mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches