Re: fixing bug in combocid.c

Heikki Linnakangas <[email protected]> Mon, 01 Sep 2008 21:55:32 +0300

Newsgroups	gmane.comp.db.postgresql.devel.patches
Organization	EnterpriseDB
Message-ID	<[email protected]>

Karl Schnaitter wrote:
> This patch is for a bug in backend/utils/time/combocid.c.
> 
> In HeapTupleHeaderAdjustCmax, the code makes the incorrect assumption 
> that the raw command id corresponds to cmin, when the raw command id can 
> in fact be a combo cid. It needs to be fixed to call 
> HeapTupleHeaderGetCmin to get cmin. That's all there is to my patch, but 
> read on for more details.

Yep. Patch committed.

Thanks for the report!

> This is my first patch; I hope I did it right!

You did well :-). No need to tar or gzip small patches like that, though.

-- 
   Heikki Linnakangas
   EnterpriseDB   http://www.enterprisedb.com

-- 
Sent via pgsql-patches mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-patches