Re: [PATCHES] updated hash functions for postgresql v1
Jeff Davis <[email protected]> Sat, 10 Jan 2009 10:16:34 -0800
| Newsgroups | gmane.comp.db.postgresql.devel.general,gmane.comp.db.postgresql.devel.patches |
|---|---|
| Message-ID | <1231611394.25019.86.camel@jdavis> |
On Sat, 2009-01-10 at 11:06 -0600, Kenneth Marshall wrote: > > Separating mix() and final() should have some performance benefit, > > right? > > > Yes, it does but the results can be swamped by other latencies in the > code path. Tests such as Tom's benchmark of the underlying functions is > needed to isolate the timings effectively or a benchmark like Greenplum's > that will benefit from a more efficient function. > Ok. I isolated the function itself by just doing: -- 10 million rows of random()::text EXPLAIN ANALYZE SELECT hashtext(t) FROM randomtext; I ran 5 times on both old and new code, eliminating the top and bottom and taking the average of the remaining 3, and I got a 6.9% performance improvement with the new code. I tried quickly with a few other data types and got similar results. It's obviously a small microbenchmark, but that's good enough for me. Thanks! Regards, Jeff Davis -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers