Re: [PATCHES] updated hash functions for postgresql v1

--001636c5a444052bc90462a62187
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Did this change hashtext() visible to users? We have been using it quite
widely for partitioning our databases. If so then it should be marked quite
visibly in release notes as there might be others who will be hit by this.

regards
Asko

On Mon, Feb 9, 2009 at 11:22 PM, Tom Lane <[email protected]> wrote:

> Kenneth Marshall <[email protected]> writes:
> > I have updated the patch posted by Jeff Davis on January 9th
> > to include the micro-patch above as well as updated the polymorphism
> > regressions tests. This applies cleanly to the latest CVS pull.
>
> Applied --- thanks for being persistent about resolving the doubts on this.
>
> One thing that apparently neither of you realized was that the
> polymorphism results were varying between bigendian and littleendian
> machines; I suppose you are using different hardware and that's why you
> didn't agree on what the results should be.
>
> Since we already agreed we were going to tolerate endianness dependence
> in the hash functions, I fixed that by adding some ORDER BYs.
>
>                        regards, tom lane
>
> --
> Sent via pgsql-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

--001636c5a444052bc90462a62187
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Did this change hashtext() visible to users? We have been using it quite wi=
dely for partitioning our databases. If so then it should be marked quite v=
isibly in release notes as there might be others who will be hit by this.<b=
r>
<br>regards<br>Asko<br><br><div class=3D"gmail_quote">On Mon, Feb 9, 2009 a=
t 11:22 PM, Tom Lane <span dir=3D"ltr">&lt;<a href=3D"mailto:[email protected]=
.us">[email protected]</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_=
quote" style=3D"border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt =
0pt 0.8ex; padding-left: 1ex;">
<div class=3D"Ih2E3d">Kenneth Marshall &lt;<a href=3D"mailto:[email protected]">=
[email protected]</a>&gt; writes:<br>
&gt; I have updated the patch posted by Jeff Davis on January 9th<br>
&gt; to include the micro-patch above as well as updated the polymorphism<b=
r>
&gt; regressions tests. This applies cleanly to the latest CVS pull.<br>
<br>
</div>Applied --- thanks for being persistent about resolving the doubts on=
 this.<br>
<br>
One thing that apparently neither of you realized was that the<br>
polymorphism results were varying between bigendian and littleendian<br>
machines; I suppose you are using different hardware and that&#39;s why you=
<br>
didn&#39;t agree on what the results should be.<br>
<br>
Since we already agreed we were going to tolerate endianness dependence<br>
in the hash functions, I fixed that by adding some ORDER BYs.<br>
<br>
 &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbs=
p; &nbsp;regards, tom lane<br>
<div><div></div><div class=3D"Wj3C7c"><br>
--<br>
Sent via pgsql-hackers mailing list (<a href=3D"mailto:pgsql-hackers@postgr=
esql.org">[email protected]</a>)<br>
To make changes to your subscription:<br>
<a href=3D"http://www.postgresql.org/mailpref/pgsql-hackers" target=3D"_bla=
nk">http://www.postgresql.org/mailpref/pgsql-hackers</a><br>
</div></div></blockquote></div><br>

--001636c5a444052bc90462a62187--