Re: libpq build problem with <io.h> on MS VC++
Tom Lane <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.devel.win32,gmane.comp.db.postgresql.devel.patches |
|---|---|
| Message-ID | <[email protected]> |
Bruce Momjian <[email protected]> writes: > OK, I have improved your comment and applied the patch. I mentioned the > problem is only on MS C, but we might as well include io.h there on all > Win32 platforms. I am actually fairly uncomfortable with this solution. We learned the hard way awhile back that we want to include postgres.h or siblings *before* any system header file, because the system header files may default to things we do not want otherwise. (Typical examples have to do with 32-bit vs 64-bit file offsets.) Perhaps it will be okay to violate that rule on this one specific file on this one specific platform, but I would not bet on it. regards, tom lane ---------------------------(end of broadcast)--------------------------- TIP 1: subscribe and unsubscribe commands go to [email protected]