Re: libpq build problem with <io.h> on MS VC++
Bruce Momjian <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.devel.win32,gmane.comp.db.postgresql.devel.patches |
|---|---|
| Message-ID | <[email protected]> |
Tom Lane wrote: > Bruce Momjian <[email protected]> writes: > > Ah, one thing we have done is to reference everything as pg* and define > > it to be the libc function on unix and give a compatibility function on > > Win32. We do that with pgpipe. That might be our best solution. > > We should do that sort of thing only as a very last resort. It's > particularly bad when we cannot easily enforce that all references use > the pgxxx function. pgpipe is manageable because there are very few > places that need to use it, but the same cannot be said of rename. > > Personally I'd rather get rid of pgpipe as well ... Yes, that is true that we can't know we hit all the places that need to use pg*. I added a comment in port.h: * There is some inconsistency here because sometimes we require pg*, like * pgpipe, but in other cases we define rename to pgrename just on Win32. -- Bruce Momjian | http://candle.pha.pa.us [email protected] | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073 ---------------------------(end of broadcast)--------------------------- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/docs/faqs/FAQ.html