Re: [PATCHES] [HACKERS] snprintf causes regression tests to fail
Nicolai Tufar <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.devel.win32,gmane.comp.db.postgresql.devel.general |
|---|---|
| Message-ID | <[email protected]> |
Neither Bruce's nor subsequent Tom's patch did not fix the issue. The command used is: make maintainer-clean && ./configure && make && make install && make check It should have be fine to recompile the source code completely. I attach the resulting config.log. May be it will give a clue. Regression test failure are in the same places as previous ones. Best regards, Nicolai On Mon, 28 Feb 2005 16:29:57 -0500 (EST), Bruce Momjian <[email protected]> wrote: > Tom Lane wrote: > > Bruce Momjian <[email protected]> writes: > > > Ah, the problem was introduced here: > > > > Right, it was my fault. > > > > > The problem is that the PGAC_FUNC_PRINTF_ARG_CONTROL call was moved > > > below the printf 64-bit tests. This commited patch moves > > > PGAC_FUNC_PRINTF_ARG_CONTROL which is after we know AC_TRY_RUN works and > > > just before printf 64-bit args are tested. > > > > This patch breaks things in a different way: you should not have moved > > the AC_LIBOBJ(snprintf) step. Also you randomly placed the arg-control > > test between a chunk of code and the comment describing same. > > Thanks. > -- > Bruce Momjian | http://candle.pha.pa.us > [email protected] | (610) 359-1001 > + If your life is a hard drive, | 13 Roberts Road > + Christ can be your backup. | Newtown Square, Pennsylvania 19073 > ---------------------------(end of broadcast)--------------------------- TIP 1: subscribe and unsubscribe commands go to [email protected]