Re: SQLExecDirectW returns SQL_SUCCESS even if sql finishes with error

"Jonah H. Harris" <[email protected]> Fri, 2 Nov 2018 12:08:47 -0400
Newsgroups gmane.comp.db.postgresql.odbc
Message-ID <CADUqk8V_N9pyjG3VNwWyMNpC0fqn3wML_kk1Lfa9-tB7j-Pg_Q@mail.gmail.com>
On Thu, Nov 1, 2018 at 10:50 PM Tom Lane <[email protected]> wrote:

> "Inoue, Hiroshi" <[email protected]> writes:
> > Could you please tell the customer that it's meaningless to set
> > client_min_messages to 'fatal' or 'panic'?
>
> Yeah, I wonder why we allow that at all.  It's basically breaking
> the wire protocol ...
>

Agreed. I'll send in a patch if you want. It appears the fatal and panic
members of client_message_level_options in guc.c could be removed. The same
options are similarly used by trace_recovery_messages, but that seems to
make sense even in that regard. Likewise, postgresql.conf.sample only shows
debug5-error as options; omitting fatal and panic. The web docs, however,
show fatal and panic as options.

Thoughts?

-- 
Jonah H. Harris