Re: [pgAdmin4][Patch] - RM 4555 - RE-SQL for Exclusion Constraint
Akshay Joshi <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.pgadmin.devel |
|---|---|
| Message-ID | <CANxoLDfyBo6vTiOOUoD5RMWk_r8aK3KbbBSerd_vT8xm+=LQvg@mail.gmail.com> |
Thanks patch applied. On Mon, Aug 5, 2019 at 2:00 PM Khushboo Vashi < [email protected]> wrote: > Hi Akshay, > > Please find the attached updated patch. > > On Mon, Aug 5, 2019 at 1:20 PM Akshay Joshi <[email protected]> > wrote: > >> Hi Khushboo >> >> Test case are working fine, some minor review comments: >> >> - Scenario name "Create/Alter Exclusion Constraint" repeating twice >> instead of that it should be more understandable. >> - File name should not be like >> "create/alter_exclusion_constraint_1.sql" it should be like >> 'alter_comment.sql'. >> >> >> Fixed. > > Thanks, > Khushboo > >> On Mon, Aug 5, 2019 at 12:30 PM Khushboo Vashi < >> [email protected]> wrote: >> >>> Hi, >>> >>> Please find the attached patch for the RE-SQL tests of the Exclusion >>> constraint node with some bug fixes in SQL. >>> >>> Thanks, >>> Khushboo >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*