Re: [RM- 4575] RE_SQL for Schema
Akshay Joshi <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.pgadmin.devel |
|---|---|
| Message-ID | <CANxoLDdZHmqPozanHujQtcdMdxhiwh-s1pguReVaq2jLYSv8HA@mail.gmail.com> |
Hi Vishal Following are my review comments: - Test cases for Schemas are not executing at all, we need to change the logic. - test.json file is not aligned properly. - Don't specify the namespaceowner/grantee/grantor as a hardcoded value to 'enterprisedb'. - Don't specify the hardcode value for "oid": 40970. On Thu, Aug 8, 2019 at 4:23 PM Vishal Sawale <[email protected]> wrote: > Hi Hackers, > > PFA the patch for RE-SQL test cases for Schema node. Please review. > > Regards, > Vishal > > > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*