Re: [pgAdmin][RM4582] pgAgent - In create job step changing "kind" (SQL/Batch) throws console error
Aditya Toshniwal <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.pgadmin.devel |
|---|---|
| Message-ID | <CAM9w-_=kBcGgz7i_bPv9Fh9uq9cTN65be7J4_fez4cXdZWUn5w@mail.gmail.com> |
Hi Hackers, Attached is the patch to update the docs for pgAgent to clarify on SQL/Batch kind. Also a minor css fix in docs. Kindly review. On Thu, Aug 8, 2019 at 6:44 PM Akshay Joshi <[email protected]> wrote: > Thanks patch applied. > > On Thu, Aug 8, 2019 at 4:40 PM Aditya Toshniwal < > [email protected]> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix console error in create step under pgAgent. >> Code is changed to use bootstrapToggle instead of bootstrapSwitch. >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > > *Sr. Software Architect* > *EnterpriseDB Software India Private Limited* > *Mobile: +91 976-788-8246* > -- Thanks and Regards, Aditya Toshniwal Software Engineer | EnterpriseDB India | Pune "Don't Complain about Heat, Plant a TREE"
RM4582.docs.patch
(application/octet-stream, 1.2 KB)
diff --git a/docs/en_US/pgagent_jobs.rst b/docs/en_US/pgagent_jobs.rst
index f0f057a6..be3b4f1b 100644
--- a/docs/en_US/pgagent_jobs.rst
+++ b/docs/en_US/pgagent_jobs.rst
@@ -69,6 +69,9 @@ Use fields on the step definition dialog to define the step:
* If you select *Batch*, use the *Code* tab to provide the batch script that
will be executed during the step.
+.. note:: The fields *Connection type*, *Database* and *Connection string* are only
+ applicable when *SQL* is selected because *Batch* cannot be run on remote servers.
+
* Use the *Connection type* switch to indicate if the step is performed on a
local server (*Local*) or on a remote host (*Remote*). If you specify a
remote connection should be used for the step, the *Connection string* field
diff --git a/docs/en_US/theme/pgadmin4/static/style.css b/docs/en_US/theme/pgadmin4/static/style.css
index 873b60de..f41e42b3 100755
--- a/docs/en_US/theme/pgadmin4/static/style.css
+++ b/docs/en_US/theme/pgadmin4/static/style.css
@@ -468,6 +468,10 @@ i, cite, em, var, address, dfn {
font-style: italic;
}
+div.note em {
+ background-color: transparent;
+}
+
em {
background-color: #fff;
}