Re: pgAdmin4 Feature Tests intermittent failures fix
Akshay Joshi <[email protected]>
| Newsgroups | gmane.comp.db.postgresql.pgadmin.devel |
|---|---|
| Message-ID | <CANxoLDeJWwbJkVk9Wtv6hM8dJhrDU_YUDUX8KEfDgda-vmt6sQ@mail.gmail.com> |
On Thu, Aug 22, 2019 at 2:41 PM Ashesh Vashi <[email protected]> wrote: > Akshay, > > On Thu, Aug 22, 2019 at 2:29 PM Akshay Joshi < > [email protected]> wrote: > >> Nice work! >> > It's big patch, and also improvement over last status. > Can we commit the patch, as to avoid any merging issues later? > Sure will do that. > > -- Thanks, Ashesh > >> >> I have run the feature test couple of times on EPAS 9.6, 11, 12 and PG >> 9.4, 10, 11, 12. Following are the review comments: >> >> - Following test cases are failing every time on *EPAS 12:* >> - Explain query with JIT stats... fails with error "*no such >> element: Unable to locate element: >> {"method":"xpath","selector":"//*[contains(string(), 'JIT')]"}*" >> - Following test cases are failing every time on *PG 12*: >> - History query sources and generated queries toggle...ERROR >> - Tests to check if Debugger is vulnerable to XSS ... ERROR >> - We have *retry_count* in "browser_tool_bar_test.py" and >> "file_manager_test.py" file. Can we make a generic function and pass the >> locator and retry_count it would be good. >> - We have also import WebDriverWait in so many files can we have one >> generic class or function for all the wait events. We will pass the >> required timeout and the locator if possible. >> >> >> >> On Wed, Aug 21, 2019 at 4:18 PM Shubham Agarwal < >> [email protected]> wrote: >> >>> Hi Hackers, >>> >>> Attached is the patch for fixing the intermittent failures encountered >>> while executing the test cases multiple times. >>> >>> Please review the patch. >>> >>> -- >>> Thanks & Regards, >>> Shubham Agarwal >>> EnterpriseDB Corporation >>> >>> The Postgres Database Company >>> >> >> >> -- >> *Thanks & Regards* >> *Akshay Joshi* >> >> *Sr. Software Architect* >> *EnterpriseDB Software India Private Limited* >> *Mobile: +91 976-788-8246* >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*